From ab484dde2a99b25027379ad89315865d00805b37 Mon Sep 17 00:00:00 2001 From: dabzpengu <97381253+dabzpengu@users.noreply.github.com> Date: Sun, 14 Apr 2024 14:31:42 +0800 Subject: [PATCH 1/3] update help link --- src/main/java/seedu/address/ui/HelpWindow.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/seedu/address/ui/HelpWindow.java b/src/main/java/seedu/address/ui/HelpWindow.java index 3f16b2fcf26..54ea755f4fa 100644 --- a/src/main/java/seedu/address/ui/HelpWindow.java +++ b/src/main/java/seedu/address/ui/HelpWindow.java @@ -15,7 +15,7 @@ */ public class HelpWindow extends UiPart { - public static final String USERGUIDE_URL = "https://se-education.org/addressbook-level3/UserGuide.html"; + public static final String USERGUIDE_URL = "https://ay2324s2-cs2103t-t08-3.github.io/tp/UserGuide.html"; public static final String HELP_MESSAGE = "Refer to the user guide: " + USERGUIDE_URL; private static final Logger logger = LogsCenter.getLogger(HelpWindow.class); From 07e2053f611011eef63bc4e4c34412a0df49e304 Mon Sep 17 00:00:00 2001 From: dabzpengu <97381253+dabzpengu@users.noreply.github.com> Date: Sun, 14 Apr 2024 15:38:17 +0800 Subject: [PATCH 2/3] update UG for explaining date and time format update constraints for the year field --- docs/UserGuide.md | 42 ++++++++++++------- .../address/model/person/InterviewTime.java | 2 +- 2 files changed, 29 insertions(+), 15 deletions(-) diff --git a/docs/UserGuide.md b/docs/UserGuide.md index ebbcffca8bb..1a9bafd5f50 100644 --- a/docs/UserGuide.md +++ b/docs/UserGuide.md @@ -67,7 +67,21 @@ contact management tasks done faster than traditional GUI apps. **4 - Lowest Priority** - This is the lowest priority. -------------------------------------------------------------------------------------------------------------------- +## Date and Time +> Your CCBot uses date and time to better help you manage your interviews. This section contains all the details on how +> your CCBot interprets date and time. + +* ### Format : `ddMMyyyyHHmm` + * `dd` - refers to the day and the acceptable range is from **01** to **31** + * `MM` - refers to the month and the acceptable range is from **01** to **12** + * `yy` - refers to the year and accepts any **4-digit** numbers from **0001** to **9999** + * `HH` - refers to the hour and the acceptable range is from **00** to **23** + * `mm` - refers to the minutes and the acceptable range is from **00** to **59** +* ### Examples: + * `121220221400` is interpreted as **December 12, 2022 4:00 PM** + * `010100010000` is interpreted as **January 01, 0001 12:00 AM** +-------------------------------------------------------------------------------------------------------------------- ## Features
@@ -402,18 +416,18 @@ This value cannot be modified or added by the `edit` or `add` commands. | **jd/** | The job difficulty (only for `sort` command) | ## Constraints Summary -| Field | Constraint | -|----------------------|----------------------------------------------------------------------------------------------------------| -| `COMPANY_NAME` | Should be less than 100 characters, and it should not be blank. | -| `NAME` | Should only contain alphanumeric characters and spaces, and it should not be blank. | -| `PHONE_NUMBER` | Should only contain numbers, and it should be at least 3 digits long. | -| `EMAIL` | Should be a valid email address. | -| `ADDRESS` | Can take any values, and it should not be blank. | -| `SALARY` | Should only contain numbers, with range [0, 2147483647] or two pure digital numbers with '-' in between. Both digital numbers should be within the range [0, 2147483647]. | -| `PROGRAMMING_LANGUAGE` | Should be alphanumeric and may contain some special characters (+ and #), and must be less than 50 characters. | -| `TAG` | Should be alphanumeric. | -| `PRIORITY` | Should be a number between 0 and 4. | -| `INTERVIEW_TIME` | Should be in the format `ddMMyyyyHHmm`. | -| `INFO` | Can take any values, and it should not be blank. | -| `EDUCATION` | Should only contain alphanumeric characters and spaces, and it should not be blank. | +| Field | Constraint | +|----------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| +| `COMPANY_NAME` | Should be less than 100 characters, and it should not be blank. | +| `NAME` | Should only contain alphanumeric characters and spaces, and it should not be blank. | +| `PHONE_NUMBER` | Should only contain numbers, and it should be at least 3 digits long. | +| `EMAIL` | Should be a valid email address. | +| `ADDRESS` | Can take any values, and it should not be blank. | +| `SALARY` | Should only contain numbers, with range [0, 2147483647] or two pure digital numbers with '-' in between. Both digital numbers should be within the range [0, 2147483647]. | +| `PROGRAMMING_LANGUAGE` | Should be alphanumeric and may contain some special characters (+ and #), and must be less than 50 characters. | +| `TAG` | Should be alphanumeric. | +| `PRIORITY` | Should be a number between 0 and 4. | +| `INTERVIEW_TIME` | Should be in the format `ddMMyyyyHHmm`.
* `dd` - refers to the day and the acceptable range is from **01** to **31**
* `MM` - refers to the month and the acceptable range is from **01** to **12**
* `yy` - refers to the year and accepts any **4-digit** numbers from **0001** to **9999**
* `HH` - refers to the hour and the acceptable range is from **00** to **23**
* `mm` - refers to the minutes and the acceptable range is from **00** to **59** | +| `INFO` | Can take any values, and it should not be blank. | +| `EDUCATION` | Should only contain alphanumeric characters and spaces, and it should not be blank. | diff --git a/src/main/java/seedu/address/model/person/InterviewTime.java b/src/main/java/seedu/address/model/person/InterviewTime.java index dd64216896b..ca80eae8768 100644 --- a/src/main/java/seedu/address/model/person/InterviewTime.java +++ b/src/main/java/seedu/address/model/person/InterviewTime.java @@ -15,7 +15,7 @@ public class InterviewTime { public static final String MESSAGE_CONSTRAINTS = "Error thrown, date and time format may be wrong. Check UG."; - public static final String REGEX_YYYY = "\\d{4}"; + public static final String REGEX_YYYY = "\"([1-9]\\\\d{3}|0\\\\d{3})\""; public static final String REGEX_DD = "(0[1-9]|[1-2][0-9]|3[01])"; public static final String REGEX_MM = "(0[1-9]|1[0-2])"; public static final String REGEX_HHMM = "^([0-1][0-9]|2[0-3])[0-5][0-9]$"; From 060292e2503226e405ab0dcc4d13d3ed1face8e0 Mon Sep 17 00:00:00 2001 From: dabzpengu <97381253+dabzpengu@users.noreply.github.com> Date: Mon, 15 Apr 2024 12:38:04 +0800 Subject: [PATCH 3/3] update UG to explain handling leap years fix UG about adding resume --- docs/UserGuide.md | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/docs/UserGuide.md b/docs/UserGuide.md index c31cddbf5fc..5d827bffa57 100644 --- a/docs/UserGuide.md +++ b/docs/UserGuide.md @@ -74,12 +74,17 @@ contact management tasks done faster than traditional GUI apps. * ### Format : `ddMMyyyyHHmm` * `dd` - refers to the day and the acceptable range is from **01** to **31** * `MM` - refers to the month and the acceptable range is from **01** to **12** - * `yy` - refers to the year and accepts any **4-digit** numbers from **0001** to **9999** + * `yyyy` - refers to the year and accepts any **4-digit** numbers from **0001** to **9999** * `HH` - refers to the hour and the acceptable range is from **00** to **23** * `mm` - refers to the minutes and the acceptable range is from **00** to **59** * ### Examples: * `121220221400` is interpreted as **December 12, 2022 4:00 PM** - * `010100010000` is interpreted as **January 01, 0001 12:00 AM** + * `010100010000` is interpreted as **January 01, 0001 12:00 AM** +> #### Handling leap years +> * Your CCBot uses the ISO-8601 calendar system to handle leap years. This means that giving a leap day on a non-leap +> year returns the last valid day of that month. +> * Example: `290220090000` will give the same output as `280220090000` +> * For more information, click [here](https://docs.oracle.com/javase/8/docs/api/java/time/LocalDateTime.html). -------------------------------------------------------------------------------------------------------------------- ## Features @@ -136,6 +141,11 @@ A person can have any number of tags (including 0) * `TAG` should be a single alphanumerical word with no spaces. * `PRIORITY` should be a number between 0 and 4. * `INTERVIEW_TIME` should be in the format `ddMMyyyyHHmm`. + * `dd` - refers to the day and the acceptable range is from **01** to **31**
+ * `MM` - refers to the month and the acceptable range is from **01** to **12**
+ * `yyyy` - refers to the year and accepts any **4-digit** numbers from **0001** to **9999**
+ * `HH` - refers to the hour and the acceptable range is from **00** to **23**
+ * `mm` - refers to the minutes and the acceptable range is from **00** to **59** * `INFO` can take any values. Examples: