Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE-D][Tester C] Efficiency parameter treated as string #162

Closed
nus-pe-script opened this issue Apr 5, 2024 · 1 comment · Fixed by #173
Closed

[PE-D][Tester C] Efficiency parameter treated as string #162

nus-pe-script opened this issue Apr 5, 2024 · 1 comment · Fixed by #173
Labels
duplicate This issue or pull request already exists efficiency_howen

Comments

@nus-pe-script
Copy link

When editing other parameters along with the efficiency, the "eff/EFFICIENCY" is simply treated as a string and attached to the previous parameter.
In the example below I tried editing address to "nus" and efficiency to 90 by entering
'edit 1 a/nus eff/90'

edit.pngedit

Labels: severity.High type.FunctionalityBug
original: VatsalVitosh/ped#7
@yiwern5 yiwern5 mentioned this issue Apr 6, 2024
Closed
@yiwern5 yiwern5 added the duplicate This issue or pull request already exists label Apr 6, 2024
@howen02
Copy link

howen02 commented Apr 11, 2024

User is not allowed to edit efficiency, removed eff/ from edit command.

@howen02 howen02 closed this as completed Apr 11, 2024
@howen02 howen02 linked a pull request Apr 11, 2024 that will close this issue
Modify user guide #173
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists efficiency_howen
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modify user guide howen02/tp
3 participants
@nus-pe-script @howen02 @yiwern5