Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All fields' constructors should be private; enforce use of factory constructors #141

Closed
aureliony opened this issue Mar 26, 2024 · 2 comments · Fixed by #275
Closed

All fields' constructors should be private; enforce use of factory constructors #141

aureliony opened this issue Mar 26, 2024 · 2 comments · Fixed by #275
Assignees
@yisiox
Labels
bug.NotAllowedToFix severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product type.Bug A bug
Milestone
v1.4

Comments

@aureliony
Copy link

If the json is modified manually by the user, the string may not be pre-processed which may lead to unintended outcome,s e.g. trailing and leading whitespaces.
@aureliony aureliony added type.Bug A bug severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product labels Mar 26, 2024
@aureliony aureliony added this to the v1.4 milestone Mar 26, 2024
@aureliony aureliony closed this as not planned Won't fix, can't repro, duplicate, stale Apr 12, 2024
@aureliony aureliony reopened this Apr 12, 2024
@aureliony
Copy link
Author

To add a note in the UG: editing the JSON file directly is a feature only for advanced users and it is the user's responsibility to ensure that the edits are valid.

@yisiox
Copy link

yisiox commented Apr 15, 2024

Update: UG issue fixed by #275

@aureliony aureliony linked a pull request Apr 15, 2024 that will close this issue
Polish UG for v1.4 release #275
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yisiox yisiox

Labels
bug.NotAllowedToFix severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product type.Bug A bug
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

Polish UG for v1.4 release AY2324S2-CS2103T-W12-3/tp
2 participants
@aureliony @yisiox