From 99c10ebf386468b6d54b6039f22521c2e27609db Mon Sep 17 00:00:00 2001 From: Romain Lalaut Date: Mon, 6 Jun 2016 15:09:48 +0000 Subject: [PATCH 1/2] Update boolean_filter : on/off support --- lib/active_interaction/filters/boolean_filter.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/active_interaction/filters/boolean_filter.rb b/lib/active_interaction/filters/boolean_filter.rb index a96d5cb9..25f5688a 100644 --- a/lib/active_interaction/filters/boolean_filter.rb +++ b/lib/active_interaction/filters/boolean_filter.rb @@ -21,9 +21,9 @@ class BooleanFilter < Filter def cast(value, _interaction) case value - when FalseClass, '0', /\Afalse\z/i + when FalseClass, '0', /\Afalse\z/i, /\Aoff\z/i false - when TrueClass, '1', /\Atrue\z/i + when TrueClass, '1', /\Atrue\z/i, /\Aon\z/i true else super From 10b6a4738af5d2a8e510a3fda687503914da255d Mon Sep 17 00:00:00 2001 From: Romain Lalaut Date: Mon, 6 Jun 2016 15:15:45 +0000 Subject: [PATCH 2/2] Update boolean_filter_specs : on/off support --- spec/active_interaction/filters/boolean_filter_spec.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/active_interaction/filters/boolean_filter_spec.rb b/spec/active_interaction/filters/boolean_filter_spec.rb index 8abc8e6a..5ef705a7 100644 --- a/spec/active_interaction/filters/boolean_filter_spec.rb +++ b/spec/active_interaction/filters/boolean_filter_spec.rb @@ -8,7 +8,7 @@ describe '#cast' do context 'falsey' do - [false, '0', 'false', 'FALSE'].each do |value| + [false, '0', 'false', 'FALSE', 'off', 'OFF'].each do |value| it "returns false for #{value.inspect}" do expect(filter.cast(value, nil)).to be_falsey end @@ -16,7 +16,7 @@ end context 'truthy' do - [true, '1', 'true', 'TRUE'].each do |value| + [true, '1', 'true', 'TRUE', 'on', 'ON'].each do |value| it "returns true for #{value.inspect}" do expect(filter.cast(value, nil)).to be_truthy end