Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While upgrading to active interaction
5.0.0
I found that theinputs must be a hash or ActionController::Parameters
argument error is being raised when inputs are composed within an interaction (i.e.compose(Multiply, inputs)
). It looks like that error will be raised unless they are a hash or anActionController::Parameters
instance when we probably want to also allow them to beInputs
for composition.I wrote two test cases, one for the
#normalized
method where the error gets raised to make sure it does not when they are of typeActiveInteraction::Inputs
and one for the#compose
method directly to ensure it is a valid outcome for both a hash or anInputs
instance.It's my first time reading through the library source, so if I'm missing anything obvious or there is a better way to approach this let me know how I can help!