Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All components: User-defined options should always be added at end #146

Closed
kevinwallimann opened this issue Jun 26, 2020 · 1 comment · Fixed by #236
Closed

All components: User-defined options should always be added at end #146

kevinwallimann opened this issue Jun 26, 2020 · 1 comment · Fixed by #236
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kevinwallimann
Copy link
Collaborator

User defined options should always override any options preset by the component, e.g. in KafkaStreamWriter

confluentAvroDataFrame
      .writeStream
      .options(extraOptions)
//...
      .option("topic", topic)
      .option("kafka.bootstrap.servers", brokers)
      .format("kafka")

In this case, the user has control, over both topic and brokers, but to be consistent, the call to .options with user-defined options should always at the end

@kevinwallimann kevinwallimann modified the milestones: v5.0.0, v4.x.0 Jun 26, 2020
@kevinwallimann kevinwallimann self-assigned this Jun 26, 2020
@kevinwallimann kevinwallimann added the bug Something isn't working label Jul 21, 2020
@kevinwallimann kevinwallimann modified the milestones: v4.x.0, v4.y.0 Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants