Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename prefix for additional properties for KafkaStreamReader #91

Open
kevinwallimann opened this issue Feb 10, 2020 · 1 comment
Open
Assignees
Labels
Milestone

Comments

@kevinwallimann
Copy link
Collaborator

Currently, additional properties for the KafkaStreamReader have to be specified with the prefix reader.options. E.g. reader.options.kafka.security.protocol or reader.options.kafka.ssl.key.password

This prefix is inconsistent with all other properties which start with decoder.avro., writer.parquet., manager.checkpoint or transformer.columns.. The properties for the KafkaStreamReader should start with reader.kafka., i.e. reader.kafka.options.kafka.security.protocol.

For additional properties like reader.options.failOnDataLoss or reader.options.minPartitions it's hard to find out which reader implementation they belong to.

Tasks

  • Change prefix for additional properties for KafkaStreamReader to reader.kafka.options.

How to migrate

  • All property keys starting with reader.options have to be replaced by reader.kafka.options
@kevinwallimann kevinwallimann added this to the v3.x.0 milestone Feb 10, 2020
@kevinwallimann kevinwallimann self-assigned this Feb 10, 2020
@kevinwallimann kevinwallimann removed this from the v3.x.0 milestone Feb 19, 2020
@kevinwallimann
Copy link
Collaborator Author

Removed milestone v3.x.0 to reduce number of breaking changes for v3.0.0. This change is not urgent as long as there is no conflict with other readers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant