Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential IBL regression #1537

Closed
ApoorvaJ opened this issue Sep 20, 2023 · 2 comments
Closed

Potential IBL regression #1537

ApoorvaJ opened this issue Sep 20, 2023 · 2 comments

Comments

@ApoorvaJ
Copy link
Contributor

ApoorvaJ commented Sep 20, 2023

The behavior of --envRad has significantly changed between the last two versions. I'm not sure if this is a regression.

This only happens when an irradiance image file is not found. In both versions, I get the warning: Image file not found: /path/to/MaterialX/irradiance/foo.hdr. But in the newer version, the result is much darker.

Is this a bug or is it on purpose?

Command: bin/Debug/MaterialXView --material "Emerald_Peaks_Wallpaper.mtlx" --envRad "foo.hdr"

On v1.38.7:
image

On v1.38.8:
image

The material can be found here.

@jstone-lucasfilm
Copy link
Member

Good catch, @ApoorvaJ, and I'm testing a proposed fix for this issue, which we can integrate into MaterialX 1.38.9.

@jstone-lucasfilm
Copy link
Member

Fixed in #1647.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants