Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build broken in 5 Oct 2024 commit 937a0e7: Imath no longer automatically provided #1888

Open
tellypresence opened this issue Oct 16, 2024 · 3 comments

Comments

@tellypresence
Copy link

tellypresence commented Oct 16, 2024

[Updated: isolated precise commit where things broke]

Had been building OpenEXR reliably prior to commit 937a0e7, at which point a change was made and now Imath (which used to be done automatically) is no longer available, breaking the build...

Build error messages:

CMake Warning at .../openexr/cmake/OpenEXRSetup.cmake:273 (find_package):
  By not providing "FindImath.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "Imath", but
  CMake did not find one.

  Could not find a package configuration file provided by "Imath" (requested
  version 3.1) with any of the following names:

    ImathConfig.cmake
    imath-config.cmake

  Add the installation prefix of "Imath" to CMAKE_PREFIX_PATH or set
  "Imath_DIR" to a directory containing one of the above files.  If "Imath"
  provides a separate development package or SDK, be sure it has been
  installed.
...
CMake Error: install(EXPORT "OpenEXR" ...) includes target "OpenEXRCore" 
    which requires target "Imath" that is not in any export set.
CMake Error: install(EXPORT "OpenEXR" ...) includes target "OpenEXR" 
    which requires target "Imath" that is not in any export set.
@cary-ilm
Copy link
Member

This may be related to #1880, could you possibly test that fix? A change to FetchContent had unintended consequences.

@tellypresence tellypresence changed the title Build broken in recent commit due to Imath not being automatically brought in Build broken in 5 Oct 2024 commit 937a0e7: Imath no longer automatically provided Oct 17, 2024
@tellypresence
Copy link
Author

This may be related to #1880, could you possibly test that fix? A change to FetchContent had unintended consequences.

Thank you for the suggestion. I tried using the code modifications in PR #1880, but still fail to build. Not sure it it's quite applicable in my case since I'm on recent version of CMake 3.30.5 (also, the library throwing errors is Imath not libdeflate)

@tellypresence
Copy link
Author

tellypresence commented Oct 17, 2024

By reverting line 292 in cmake/OpenEXRSetup.cmake to use FetchContent_Populate Imath again populates automatically.

[Updated] For now I will patch cmake/OpenEXRSetup.cmake to revert to FetchContent_Populate. This will allow me to stay up to date with new OpenEXR releases for the time being

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants