Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Failure to use correct namespace macros #1911

Open
barretpj opened this issue Nov 7, 2024 · 1 comment
Open

Regression: Failure to use correct namespace macros #1911

barretpj opened this issue Nov 7, 2024 · 1 comment

Comments

@barretpj
Copy link

barretpj commented Nov 7, 2024

This has been broken, yet again.

I have to build with custom namespaces, so my openexr CMAKE_OPT has
-DOPENEXR_IMF_NAMESPACE=FL_Imf -DILMTHREAD_NAMESPACE=FL_IlmThread -DIEX_NAMESPACE=FL_Iex

Here's a patch against 3.3.1 that tidies it up.
namespace_patch.txt

(patch updated from original as I caught another one in website)

@cary-ilm
Copy link
Member

cary-ilm commented Nov 7, 2024

Sorry about that, and thanks for the catch and the patch. We'll get the fix into the next release.

Our CI checks (and most of the code we commonly work on) don't currently validate the custom namespace feature, an oversight. We'll add that shortly, which should hopefully avoid this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants