-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tweaks to data collection #41
Comments
1 - If we didnt give people it would mess up the aggregate table because if a user changes settings after completing the whole thing then it would appear as they have completed the whole thing with new settings which would be in accurate. Maybe we don't need to maintain an aggregate table and all the calculations can be done at the analytics stage? Alternatively if we want to keep the aggregate table we could keep the ID switching process and add an additional table that tracked ID changes. ie:
With this setup you can basically just count how many entries there are to see how many times settings have been changed. This way we can still maintain an accurate aggregate table.
{
a: 1,
b: 3,
c: 2
} probably wouldnt be hard to switch too. {
a: {
score: 0,
correctGueses: 4,
wrongGueses: 2
},
b: {
score: 3,
correctGueses: 3,
wrongGueses: 0
},
c: {
score: 2,
correctGueses: 4,
wrongGueses: 1
}
} It would be fairly easy change to make. However, I have a few questions about how you are doing your parsing. Right now we just dump the progress as a JSON string. If I changed the shape of the JSON like suggested you would have to make your code handle both shapes being in the database. Alternatively if you dont want to do that I could add an extra column to the DB to collect this data? |
We don't need to maintain the aggregate table. We can create aggregated data pretty easily now... About parsing - its won't be hard to parse it anyway, but if it was in a extra column – that would be easier for sure! |
Cool ill just stop putting anything into the aggregate table. This means the grafana dashboards will stop updating but thats not the end of the world just something to bear in mind. Ill keep the data in the Tried to be a bit lazy and avoid DB schema migration by doing JSON data as strings but looks like thats come back to bite me, lesson learned |
The text was updated successfully, but these errors were encountered: