-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dns.ipset_file setting #4686
Conversation
follow ! need this, dynamic update ipset domain |
Good day and apologies for the long wait. It's generally better to propose a feature in an issue first, but since it's already done, can I ask, what is the problem you are trying to solve? Is the ipset configuration really getting this large? |
For example: https://github.com/hellodword/GFWList2AGH-ipset/blob/assets/ipset.txt |
I can see that these are lists of upstreams, correct? How is it related to ipsets? |
For most usage in my country, So the |
For example:
|
Hm, I see. We'll review the change then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also:
-
Merge the current
master
branch or rebase your branch on top of it, optionally with a squash. -
Describe the changes in
CHANGELOG.md
.
Updates #4686. * commit '10a8f7964482fd07502ac041ef92b4ea8adb3c3a': all: imp chlog all: imp docs feat: add dns.ipset_file setting
Thanks for the contribution! |
Updates AdguardTeam/AdGuardHome#4686. Squashed commit of the following: commit 674e70d6ad3f87207f2511724e414be44a758336 Author: Ainar Garipov <[email protected]> Date: Mon Sep 12 16:43:14 2022 +0300 Configuration: add ipset_file
just like the upstream_dns_file