Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring DNS cache size #947

Closed
ameshkov opened this issue Aug 21, 2019 · 5 comments
Closed

Allow configuring DNS cache size #947

ameshkov opened this issue Aug 21, 2019 · 5 comments
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

Currently, we're using the small default cache sizes. We should make them configurable instead.

  • cache_size -- DNS cache size
  • safebrowing_cache_size -- safebrowsing service cache size
  • parental_cache_size -- parental control service cache size

Default values should be relatively small, I think 5000 for each should be enough.

@szolin
Copy link
Contributor

szolin commented Aug 22, 2019

we're using the small default cache sizes

Current DNS cache size is 1000 elements.
However, current safebrowing/parental/safesearch cache size is 64k elements.

@ameshkov
Copy link
Member Author

However, current safebrowing/parental/safesearch cache size is 64k elements.

Yeah, and it makes little sense to have them that big by default:)

@skydrome
Copy link

skydrome commented Aug 24, 2019

can we get a setting to modify ttl values also? Or does defaultCacheTime ignore ttl?

@thueske
Copy link

thueske commented Aug 26, 2019

+1

@ameshkov
Copy link
Member Author

@skydrome yep, there will be a value for safebrowsing/parental caches TTL.

@adguard adguard closed this as completed in 3b98461 Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants