Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot download file larger than 2Gb #148

Closed
ameshkov opened this issue Oct 29, 2015 · 2 comments
Closed

Cannot download file larger than 2Gb #148

ameshkov opened this issue Oct 29, 2015 · 2 comments
Assignees
@Revertron
Labels
Bug
Milestone
2.1 patch

Comments

@ameshkov
Copy link
Member

http://forum.adguard.com/showthread.php?7259-Android-TV&p=64466#post64466
@ameshkov ameshkov added the Bug label Oct 29, 2015
@ameshkov ameshkov added this to the 2.2 milestone Oct 29, 2015
@ameshkov
Copy link
Member Author

We shouldn't simply compare seqno and ackno (because when they overflow we get nothing).
Instead we should use a functions like these:

#define TCP_SEQ_LT(a,b)     ((s32_t)((u32_t)(a) - (u32_t)(b)) < 0)
#define TCP_SEQ_LEQ(a,b)    ((s32_t)((u32_t)(a) - (u32_t)(b)) <= 0)
#define TCP_SEQ_GT(a,b)     ((s32_t)((u32_t)(a) - (u32_t)(b)) > 0)
#define TCP_SEQ_GEQ(a,b)    ((s32_t)((u32_t)(a) - (u32_t)(b)) >= 0)

@ameshkov
Copy link
Member Author

We should ping back when it is fixed:
http://forum.adguard.com/showthread.php?7259-Android-TV

@ameshkov ameshkov modified the milestones: 2.1 patch, 2.2 Oct 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Revertron Revertron

Labels
Bug
Projects
None yet
Milestone
2.1 patch
Development

No branches or pull requests
2 participants
@Revertron @ameshkov