Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"HTTPS filtering is off" SnackBar covers Data Saved stat on Home Screen #3292

Closed
vyanovsky opened this issue Dec 31, 2019 · 4 comments
Closed

Comments

@vyanovsky
Copy link

vyanovsky commented Dec 31, 2019

Where: Home screen

In Japanese, German, Russian, Ukranian and other languages, where text "HTTPS filtering is off" goes to second line, SnackBar covers Data Saved stat and users can't see the stat.

Image from iOS (2)

@artemiv4nov
Copy link
Contributor

@AlikhanAliev do you have any suggestions?

@artemiv4nov artemiv4nov added this to the 3.4 milestone Jan 9, 2020
@artemiv4nov
Copy link
Contributor

artemiv4nov commented Jan 21, 2020

@admitrevskiy
there are some updates for the task.

We don't need anymore to make the snack bar swipeable.
Instead, we should add the third button "Use without https filtering" (between two existing) to the dialog about the HTTPs filtering.
Moreover, when the user taps to the new button, we should show the confirm-dialog.

@ameshkov
Copy link
Member

Make the third button "red" to emphasize that we don't recommend it.

@admitrevskiy
Copy link

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants