Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGa crashes when Android WebView unloads #5521

Closed
5 of 6 tasks
TPS opened this issue Nov 26, 2024 · 7 comments
Closed
5 of 6 tasks

AGa crashes when Android WebView unloads #5521

TPS opened this issue Nov 26, 2024 · 7 comments

Comments

@TPS
Copy link
Contributor

TPS commented Nov 26, 2024

Please answer the following questions for yourself before submitting an issue

  • Filters were updated before reproducing an issue
  • I checked the knowledge base and found no answer
  • I checked to make sure that this issue has not already been filed

AdGuard version

4.7n57

Environment

  • OS version: Android 12
  • Device: 1+ N200 5g

HTTPS filtering

  • yes, I do

Root access

  • yes, I have it

Integration with AdGuard VPN

  • yes, I do

Routing mode

Local VPN

Ad Blocking

AdGuard Base filter, AdGuard Mobile Ads filter

Privacy

AdGuard Tracking Protection filter, AdGuard URL Tracking filter, Legitimate URL Shortener, Peter Lowe's Blocklist

Social

AdGuard Social Media filter

Annoyances

AdGuard Annoyances filter, Adblock Warning Removal List, I don't care about cookies, Dandelion Sprout's Annoyances List

Security

Online Malicious URL Blocklist, NoCoin Filter List

Language-specific

AdGuard Chinese filter, AdGuard Dutch filter, AdGuard French filter, AdGuard German filter, AdGuard Japanese filter, AdGuard Russian filter, AdGuard Spanish/Portuguese filter, AdGuard Turkish filter, AdGuard Ukrainian filter, CJX's Annoyances List, Polish Annoyances Filters, Polish Anti Adblock Filters, Polish Anti-Annoying Special Supplement, Polish GDPR-Cookies Filters, RU AdList - Counters

Other

AdGuard Experimental filter

Which DNS server do you use?

Open DNS

DNS protocol

DNS-over-HTTPS

Custom DNS

No response

What Stealth Mode options do you have enabled?

Block trackers, Remove tracking parameters from URLs, Hide your search queries, Ask websits not to track you, Self-destruction of third-party cookies, Block ETag and If-None-Match headers, Disable WebRTC, Block Push API, Block Location API, Hide your Referrer from third-parties, Hide your User Agent, Hide your IP address, Remove X-client-Data header from HTTP request, Protect against DPI

Issue Details

Steps to reproduce:

  1. Load AGa
  2. Wait for OS to or manually kill Android Webview

Expected Behavior

  • AGa shouldn't load Android Webview unless Private Browser is currently being used, & should unload it immediately after
  • AGa shouldn't crash if Webview is killed

Actual Behavior

  • AGa constantly runs Webview
  • If Webview is killed, all of AGa goes with it

Screenshots

No screenshots possible? Just the disappearance of AGa suddenly when Webview's killed.

Additional Information

This might be a real solution for @snhv's #5518.

@Versty
Copy link
Member

Versty commented Nov 27, 2024

@TPS Thank you for reporting!
This problem reproduces on our side as well. The crash will be fixed soon.

Unfortunately, the Webview start is currently can not be moved to the Private Browser start phase due to technical reasons.

@adguard-bot adguard-bot assigned Deneno and unassigned Versty Nov 27, 2024
@TPS
Copy link
Contributor Author

TPS commented Nov 27, 2024

Unfortunately, the Webview start is currently can not be moved to the Private Browser start phase due to technical reasons.

So how's this planning to be fixed? The OS may unload WebView anytime it wants & perceives it's not actively being used. If it does, will Private Browsing cease to work until AGa itself restarts? This seems… weird.

@TPS
Copy link
Contributor Author

TPS commented Nov 29, 2024

@Numci I just installed v4.7n59, which changelog says fixes this. Unfortunately, it fails the exact same way as above. What now?

@maxikuzmin
Copy link
Contributor

@TPS please update to RC 2, version will be released soon, we fixed this bug

@TPS
Copy link
Contributor Author

TPS commented Nov 30, 2024

No, all versions since AGa Private Browser is introduced (pre-v4.7n57 through v4.8n5 inclusive) still crash identically — this is not fixed!

@cyberboh
Copy link

For me, it is not resolved even in 4.8n3, AdGuard crash / closes whener WebView updated / closes.

@Versty @maxikuzmin Please re-open this issue.

@TPS
Copy link
Contributor Author

TPS commented Dec 20, 2024

@Numci @maxikuzmin @Versty When should we expect an actual fix to test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants