Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support :-abp-*() syntax #30

Closed
theseanl opened this issue May 16, 2017 · 3 comments
Closed

Support :-abp-*() syntax #30

theseanl opened this issue May 16, 2017 · 3 comments
Assignees
Milestone

Comments

@theseanl
Copy link
Contributor

theseanl commented May 16, 2017

ABP is introducing backward-compatible syntaxes [-abp-has and [-abp-has-text.
https://issues.adblockplus.org/ticket/3143
https://issues.adblockplus.org/ticket/5249
We need to convert them into :has and :contains respectively.

@ameshkov
Copy link
Member

-abp should be just an alias for our existing -ext

@ameshkov ameshkov added this to the 1.0.7 milestone Jun 17, 2017
@ameshkov
Copy link
Member

@seanl-adg I've been thinking about it lately and after all, I suppose we should support this syntax natively (talking about :-abp-has()).

It's not hard to do, and it'd be easier for people to import external filter lists which use that syntax.

Here is what should be done:

  1. Support :-abp-has() as a synonym to has
  2. Release an updated 1.0.8 version
  3. Update product-specific issues about upgrading ExtCss -- add information about parsing #?# and :-abp-has

@ameshkov ameshkov reopened this Jul 11, 2017
@theseanl
Copy link
Contributor Author

They changed their syntax to -abp-contains instead of -abp-has-text

@theseanl theseanl changed the title Support [-abp-*] syntax Support :-abp-*() syntax Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants