Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect parsing of styles #57

Closed
theseanl opened this issue Jan 12, 2018 · 1 comment
Closed

Incorrect parsing of styles #57

theseanl opened this issue Jan 12, 2018 · 1 comment
Assignees
@theseanl
Labels
bug
Milestone
1.10

Comments

@theseanl
Copy link
Contributor

theseanl commented Jan 12, 2018 •
edited
Loading

Steps to reproduce:

(new ExtendedCss(':contains(/[\\w]{9,}/) { display:none!important; }')).apply()

Expected:

No error is printed in the console.

Actual:

Extended selector is invalid: /)
Extended selector is invalid: :contains(/[\w]
@theseanl theseanl self-assigned this Jan 12, 2018
@ameshkov ameshkov added this to the 1.10 milestone Jan 12, 2018
@ameshkov ameshkov added the bug label Jan 12, 2018
@ameshkov
Copy link
Member

Let's change the interface of ExtendedCss, let it accept a list of selectors instead of the current interface.

@theseanl theseanl mentioned this issue Jan 14, 2018
Merged
@ameshkov ameshkov reopened this Mar 19, 2018
adguard pushed a commit that referenced this issue Aug 24, 2020
@slavaleleka
Pull request #57: AG-2145 implement :attr-matches()
066a61e 
Merge in EXTENSIONS/extended-css from feature/AG-2145 to master

* commit 'a3ad8866b84e09f22cd1e996b0a0f5f956744b94':
  refactor again + make validation better
  add simple pseudo arg validation, minimize regexps for strict equality
  improve syntax
  fix one more readme typo
  fix one more readme typo
  fix readme typo
  update readme
  refactor after review
  implement :attr-matches() pseudo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theseanl theseanl

Labels
bug
Projects
None yet
Milestone
1.10
Development

No branches or pull requests
2 participants
@ameshkov @theseanl