Skip to content
This repository has been archived by the owner on Oct 14, 2021. It is now read-only.

Possibly(?) incorrect parsing in ​/v3​/version​/{version} #366

Closed
tushev opened this issue Mar 6, 2021 · 1 comment
Closed

Possibly(?) incorrect parsing in ​/v3​/version​/{version} #366

tushev opened this issue Mar 6, 2021 · 1 comment
Labels
bug Something isn't working wontfix This will not be worked on
Milestone

Comments

@tushev
Copy link

tushev commented Mar 6, 2021

Describe the bug
While testing the version parser in the API, I noticed an unusual response, like "semver": "11.0.9+111.1".

To Reproduce
Steps to reproduce the behavior:

  1. Go to ​/v3​/version​/{version}: https://api.adoptopenjdk.net/swagger-ui/#/Version/get_v3_version__version_
  2. Enter 11.0.9.1+11.1 in Version, hit Execute
  3. Receive the JSON:
{
  "adopt_build_number": 1,
  "build": 11,
  "major": 11,
  "minor": 0,
  "openjdk_version": "11.0.9.1+11.1",
  "patch": 1,
  "security": 9,
  "semver": "11.0.9+111.1"
}

Expected behavior
I am not sure that "semver": "11.0.9+111.1" is a valid response. Please confirm or refute this.

Definitely not a critical/blocking issue, just noticed this and letting you know...

@tushev tushev added the bug Something isn't working label Mar 6, 2021
@johnoliver
Copy link
Member

This is a result of the issue we had where Java versions cannot be represented fully in semver due to semver being limited to 3 version numbers, that resulted in the (100*b)+x format you noted at adoptium/temurin-build#2248 (comment) unfortunately I think the only long term solution is to not use semver if/when we move to v4 api, until then I think we will be parsing in this way.

@karianna karianna added the wontfix This will not be worked on label Mar 19, 2021
@karianna karianna added this to the March 2021 milestone Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants