Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Adyen Hybris plugin] [Card Payment] strict cart validations #483

Open
vinaykumarpendyamext opened this issue Nov 21, 2024 · 1 comment
Open

Comments

@vinaykumarpendyamext
Copy link

Describe the bug

In Delijn for the merchant Account AD_ECOM_WEB, we have configured Card payment method.
we have done a POC to integrate Adyen plugin with SAP Commerce, during analysis we have observed that for the payment method call and for placing an order some strict cart validations have been implemented which do not align with every SAP commerce implementation.

Commerce implementation: Delijn
SAP Commerce version: 2211
Test Merchant Account: AD_ECOM_WEB
Adyen Hybris plugin version: 13.0.0
Adyen API version: 71
Payment method: card
environment: test

To Reproduce

  1. Go to drop in
  2. select card payment method
  3. enter card details
  4. click on Pay
  5. Payment fails due to strict cart validation

Desktop (please complete the following information):

  • OS: Windows 11
  • Chrome
  • Version: 131.0.6778.85

Additional context
Code reference: com.adyen.commerce.controllerbase.PlaceOrderControllerBase.isCartValid()

While placing an order and while calling payments method API, cart validation gets triggered which look for below information on the current cart

  • delivery address
  • delivery mode
  • tax value
  • isCalculated

In Delijn context or any standard SAP Commerce implementation above fields are not necessarily populated against the cart. In order to make use of Adyen Sap Commerce plugin we have to populate the above information to the cart even though it doesn't require from the business point of view.
Even though we can customize this, but this validation is done in private method which resides in the super class of Controller.

with this issue we are recommending changes to the cart validation so that it can be more flexible to accommodate and would cause less overhead of customization.
this unwanted validations blocks use of plugins.

@vinaykumarpendyamext
Copy link
Author

Can you pls look into this issue as it is of high priority from client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant