Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract Upgrade: v36-Reserve #10399

Closed
Chris-Hibbert opened this issue Nov 4, 2024 · 0 comments · Fixed by #10541
Closed

Contract Upgrade: v36-Reserve #10399

Chris-Hibbert opened this issue Nov 4, 2024 · 0 comments · Fixed by #10541
Assignees
Labels

Comments

@Chris-Hibbert
Copy link
Contributor

Chris-Hibbert commented Nov 4, 2024

What is the Problem Being Solved?

As mentioned in #8158, we need the ability to restart all vats. This issue is concerned with restarting v36-Reserve.

Description of the Design

The reserve is build from assetReserve.js,

assetReserve-upgrade.test.js shows that the contract is upgradeable. Look there for approaches and tests. I don't think that test shows that assets survive.

I think the only mechanism that shows that is writing to vstorage, so I'd like a test that reads allocations, adds a few IST using makeAddCollateralInvitation, and then checks that allocations increased.

Security Considerations

The reserve is holding some assets.

Scaling Considerations

No performance concerns.

Test Plan

Show that the reserve survives upgrade.

Upgrade Considerations

As above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants