You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
assetReserve-upgrade.test.js shows that the contract is upgradeable. Look there for approaches and tests. I don't think that test shows that assets survive.
I think the only mechanism that shows that is writing to vstorage, so I'd like a test that reads allocations, adds a few IST using makeAddCollateralInvitation, and then checks that allocations increased.
Security Considerations
The reserve is holding some assets.
Scaling Considerations
No performance concerns.
Test Plan
Show that the reserve survives upgrade.
Upgrade Considerations
As above.
The text was updated successfully, but these errors were encountered:
What is the Problem Being Solved?
As mentioned in #8158, we need the ability to restart all vats. This issue is concerned with restarting
v36-Reserve
.Description of the Design
The reserve is build from assetReserve.js,
assetReserve-upgrade.test.js shows that the contract is upgradeable. Look there for approaches and tests. I don't think that test shows that assets survive.
I think the only mechanism that shows that is writing to vstorage, so I'd like a test that reads
allocations
, adds a few IST usingmakeAddCollateralInvitation
, and then checks thatallocations
increased.Security Considerations
The reserve is holding some assets.
Scaling Considerations
No performance concerns.
Test Plan
Show that the reserve survives upgrade.
Upgrade Considerations
As above.
The text was updated successfully, but these errors were encountered: