Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core-Eval to change policy #10507

Closed
1 task
LuqiPan opened this issue Nov 18, 2024 · 1 comment · Fixed by #10609
Closed
1 task

Core-Eval to change policy #10507

LuqiPan opened this issue Nov 18, 2024 · 1 comment · Fixed by #10609
Assignees
@dckc
Milestone
FU2: SwingSet int...

Comments

@LuqiPan
Copy link
Contributor

LuqiPan commented Nov 18, 2024 •
edited by dckc
Loading

What is the Problem Being Solved?

C2 - ... BLD stakers MUST be able to revise the policy through a core-eval that updates what is written to vstorage.

Description of the Design

follows...

Security Considerations

It's important to keep in mind that while the contract can state the confirmation policy, it cannot observe the relevant events on other blockchains in order to enforce the policy. The contract relies on the OCW to report external events accurately.

Scaling Considerations

Test Plan

  • bootstrap test to show that core-eval affected policy in vstorage

Upgrade Considerations

This is an upgrade feature.
@LuqiPan LuqiPan added this to the FU2: SwingSet integration milestone Nov 18, 2024
@dckc dckc added the BLOCKED Raise visibility when progress is impeded label Nov 18, 2024
@dckc
Copy link
Member

dckc commented Nov 22, 2024

The way #10512 was addressed (in #10532) is that the contract never sees the chain policy.

Does that make this issue moot?

@dckc dckc changed the title Core-Eval to null-upgrade to change policy Core-Eval to change policy Nov 25, 2024
@LuqiPan LuqiPan removed the BLOCKED Raise visibility when progress is impeded label Dec 2, 2024
@dckc dckc mentioned this issue Dec 3, 2024
Merged
@mergify mergify bot closed this as completed in #10609 Dec 8, 2024
@mergify mergify bot closed this as completed in 1645d7e Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dckc dckc

Labels
None yet
Projects
None yet
Milestone
FU2: SwingSet integration
Development

Successfully merging a pull request may close this issue.

feat(fast-usdc): core-eval to change fastUsdc.feedPolicy Agoric/agoric-sdk
2 participants
@dckc @LuqiPan