Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f:fast-usdc a3p tests are failing but CI still passes #10657

Closed
anilhelvaci opened this issue Dec 9, 2024 Discussed in #10654 · 0 comments · Fixed by #10641
Closed

f:fast-usdc a3p tests are failing but CI still passes #10657

anilhelvaci opened this issue Dec 9, 2024 Discussed in #10654 · 0 comments · Fixed by #10641
Assignees

Comments

@anilhelvaci
Copy link
Collaborator

Discussed in #10654

Originally posted by anilhelvaci December 9, 2024

Context

The reason why I raise this as a "Discussion" question is that I'm not sure if this is the intended behavior and worth opening an issue for it. So please let me know if this is an issue, I'll convert to it immediately.

Problem Definition

a3p tests for f:fast-usdc currently check that agoricNames.instance has a property called fastUsdc. In the current version of master (a66f6a1408016746f4f480241f3d6efa53732841) start-fast-usdc.js core eval fails so fastUsdc does not end up in agoricNames.instance.

I have noticed that this behavior goes unnoticed when yarn test -m fast-usdc is run. I also noticed that in the CI as well. Here's a recent CI run that passed however f:fast-usdc/test.sh fails.

https://github.com/Agoric/agoric-sdk/actions/runs/12225954791/job/34100571062?pr=10643#step:10:179

Same thing in #10609 => https://github.com/Agoric/agoric-sdk/actions/runs/12225957386/job/34100576932?pr=10609#step:10:178

When set -ueo pipefail added on top of test.sh, yarn test -m fast-usdc fails.

Next Steps

Please let me know if this is intended or deserves an issue. @dckc @turadg @Chris-Hibbert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants