Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Hooks are misclassified if versions don't match #10681

Closed
michaelfig opened this issue Dec 11, 2024 · 0 comments · Fixed by #10683
Closed

Address Hooks are misclassified if versions don't match #10681

michaelfig opened this issue Dec 11, 2024 · 0 comments · Fixed by #10683
Assignees
@michaelfig
Labels
agd Agoric (Golang) Daemon bug Something isn't working

Comments

@michaelfig
Copy link
Member

michaelfig commented Dec 11, 2024 •
edited
Loading

The Address Hooks implementation should not pass through hooked addresses with a mismatched version nibble as if they were not hooked. Instead, such addresses should be rejected for using an unsupported version, allowing us to introduce such functionality in the future.

Originally posted by @gibson042 in #10613 (review)
@michaelfig michaelfig self-assigned this Dec 11, 2024
@michaelfig michaelfig added bug Something isn't working agd Agoric (Golang) Daemon labels Dec 11, 2024
@michaelfig michaelfig mentioned this issue Dec 11, 2024
Merged
@mergify mergify bot closed this as completed in #10683 Dec 13, 2024
@mergify mergify bot closed this as completed in ddff762 Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelfig michaelfig

Labels
agd Agoric (Golang) Daemon bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(address-hooks): version robustness and hardening Agoric/agoric-sdk
1 participant
@michaelfig