Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elide comments option to agoric run CLI command #10868

Open
mhofman opened this issue Jan 21, 2025 · 0 comments
Open

Add elide comments option to agoric run CLI command #10868

mhofman opened this issue Jan 21, 2025 · 0 comments
Labels
agoric-cli package: agoric-cli enhancement New feature or request

Comments

@mhofman
Copy link
Member

mhofman commented Jan 21, 2025

What is the Problem Being Solved?

agoric run and core proposals currently create different bundles from the same source because the former enables elideComments and the latter doesn't.

When updating proposal builders, we'd like to be able to generate proposals using the same bundles that are published during a software upgrade containing a core proposal (e.g. DCFoundation/cosmos-proposal-builder#59).

Currently that requires patching agoric-sdk to revert both 2abea2d and 2d410c7

Description of the Design

A command line option to agoric run or another dynamic way to disable elide comments.

An alternative is to align the core proposal builder to use elideComments

Security Considerations

None

Scaling Considerations

This will create larger bundles (which may not be able to be published through cosmos tx), but the goal is to be able to re-use large bundles that were already published during core proposals

Test Plan

Integration test (likely a3p-integration) that verifies a cli built bundle is the same as one published by core proposal.

Upgrade Considerations

Changes chain software but doesn't strictly affect running chain code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agoric-cli package: agoric-cli enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant