feat: marshal based on user's petnames #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katelynsills
changed the title
erights
approved these changes
May 12, 2020
There was a problem hiding this comment.
LGTM
This is a great start on a petname system. What is here is all valid. Future directions (not in this PR please!):
A more full featured petname system would enable the user to assign and change petnames for existing objects afterwards. Ideally, all renderings of that petname on a UI would be updated then. My android phone contacts lists seems to do this perfectly.
A more full featured petname system would have gentler fallbacks before retreating to unnamed-37, such as pathnames. However, pathnames depends on more information being available than can be available to this module or communicated through marshal.
erights
requested changes
May 12, 2020
warner
reviewed
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a library for hydrating and dehydrating values based on a system of the user's petname maps. The next step is using this library in the wallet.