feat(cosmic-swingset): add board, use board in mailboxAdmin #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katelynsills
force-pushed
the
1166-add-board
branch
from
9a4bacc to
be66f2e
Compare
michaelfig
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1166
This PR adds the "board", a registry-like vat which allows users to add a value and get a key for that value. The key is a non-human-readable string and can be shared widely. Users can retrieve a value by giving the board the key. Keys and values are in a bidirectional one-to-one mapping. If a user attempts to add a value that has already been added, they get the old id.
This PR changes the mailbox vat to use the board rather than the registry.
Unit tests are added for the board, and tests of
home.boardandhome.mailboxAdminare also added.With this PR, users can now send and receive payments, but they can't use the wallet UI to do so yet. They can use deploy scripts or the REPL.