You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think this was a typo, because this PR did not also rename packages/produce-promise/everything to packages/producePromise/. This doesn't seem to be hurting anything (maybe yarn just ignores a workspace entry when the corresponding directory is missing?), but it effectively deletes @agoric/produce-promise. So @erights you might as well go ahead and make a PR to delete the packages/produce-promise/ directory, this entry in workspaces, and the .github/workflows/test-all-packages.yml job.
The text was updated successfully, but these errors were encountered:
@michaelfig oh, did we want to publish "one last version" of @agoric/produce-promise with a deprecation message and a README that points users at the new name?
Probably not important, but if we did want to do that, then before deleting producePromise, we'd want to rename it back to produce-promise, add the deprecation stuff, make a release, and then delete it.
Probably not important, but if we did want to do that, then before deleting producePromise, we'd want to rename it back to produce-promise, add the deprecation stuff, make a release, and then delete it.
I think it is legitimate to branch off of an earlier commit, make and tag a release, and never have that tag hit the main branch.
About
agoric-sdk/package.json
Line 18 in d9bc9ec
at
#1329 (review)
@warner writes:
The text was updated successfully, but these errors were encountered: