fix: have liveSlots reject Promise arguments in D() invocations #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warner
force-pushed
the
1766-reject-callNow-promises
branch
2 times, most recently
from
c5ce255 to
9c5e52d
Compare
This is in addition to the kernel-side translator killing the vat if one gets through. Using a promise in `syscall.callNow()` is vat-fatal. Using one in `D()` merely throws an Error (thrown by liveslots before the syscall is made). closes #1358
warner
force-pushed
the
1766-reject-callNow-promises
branch
from
9c5e52d to
1cf5fac
Compare
|
I updated the test, lemme know if I got it right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in addition to the kernel-side translator killing the vat if one gets
through. Using a promise in
syscall.callNow()is vat-fatal. Using one inD()merely throws an Error (thrown by liveslots before the syscall ismade).
closes #1358