Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC can propose and vote on changes to oracle operators list #6701

Closed
Tracked by #25 ...
turadg opened this issue Dec 20, 2022 · 6 comments · Fixed by #6977
Closed
Tracked by #25 ...

EC can propose and vote on changes to oracle operators list #6701

turadg opened this issue Dec 20, 2022 · 6 comments · Fixed by #6977
Assignees
Labels
enhancement New feature or request vaults_triage DO NOT USE

Comments

@turadg
Copy link
Member

turadg commented Dec 20, 2022

What is the Problem Being Solved?

To support Agoric/dapp-econ-gov#35

Description of the Design

TBD

Should this be the EC invitation or a new price feed admin invitation distributed to the EC members?

The EC invitation should suffice. If we decide to make a separate oracle admin electorate, the electorate is a governed param, so we can change it at that time. An invitation to a new electorate is also likely to meet requirements, if that's more straightforward.

Should the invitation be to administer oracles for all oracle-based price feeds, or a particular one?

TBD

Should the proposal be for addition/removal or a specific list? If a list, the contract can resolve the add/remov. If add/remove, is it singular or a list?

Product says add/remove singular.

Tech details

Make the priceaggregator contract governed.
Then we can allow the EC go call its methods to add and remove oracles.
Smart wallet will also need to support api calls if it doesn't already.

For revoking the existing oracles, try the Caretaker pattern.
The caretaker itself should be virtual to not consume RAM (though since there are so few, it's arguable that it should just be noted as a scaling consideration).

Security Considerations

Test Plan

@dckc
Copy link
Member

dckc commented Dec 20, 2022

Should this be the EC invitation or a new price feed admin invitation distributed to the EC members?

The EC invitation should suffice. If we decide to make a separate oracle admin electorate, the electorate is a governed param, so we can change it at that time.

An invitation to a new electorate is also likely to meet requirements, if that's more straightforward. I can't imagine that it is.

@otoole-brendan otoole-brendan added the vaults_triage DO NOT USE label Jan 3, 2023
@ivanlei
Copy link
Contributor

ivanlei commented Jan 22, 2023

Per @rowgraus in slack on 01/20/2023

Based on EC conversation yesterday, they did not believe they needed control over the oracle nodes or feeds on launch. This is different from what I had heard previously and is more aligned with Dean’s goal that Simply Staking instead is in charge of that. Based on Chainlink’s responses today it sounds like this control also hasn’t been required by them in production, which makes me feel better. Hopefully this might save some governance work on our end.

Thus closing this.

@ivanlei ivanlei closed this as completed Jan 22, 2023
@ivanlei ivanlei reopened this Jan 22, 2023
@ivanlei
Copy link
Contributor

ivanlei commented Jan 22, 2023

Reopening based on changing requirements. @rowgraus please help clarify.

@otoole-brendan
Copy link
Contributor

Subject to discussion today in Inter Proto meeting

@otoole-brendan
Copy link
Contributor

@turadg discussed with @dckc that it made sense to assign to you, lmk if we got that wrong

@dckc

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vaults_triage DO NOT USE
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants