Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deeplyFullfilledObect types fail with Board #6787

Closed
turadg opened this issue Jan 13, 2023 · 1 comment
Closed

deeplyFullfilledObect types fail with Board #6787

turadg opened this issue Jan 13, 2023 · 1 comment
Assignees
@turadg
Labels
bug Something isn't working devex developer experience vaults_triage DO NOT USE

Comments

@turadg
Copy link
Member

turadg commented Jan 13, 2023

Describe the bug

@dckc encountered https://gist.github.com/dckc/65d81f68228f35696e4b341f8983cd9d

To Reproduce

  1. Create an object with properties from promise space for the terms of WalletFactory start.
  2. Use deeplyFulfilledObject to provide them as terms to startInstance

Products an error, that board is compatible because getPublishingMarshaller is.

Expected behavior

No errors.
@turadg turadg added bug Something isn't working devex developer experience labels Jan 13, 2023
@turadg turadg self-assigned this Jan 13, 2023
@rowgraus rowgraus added the vaults_triage DO NOT USE label Feb 6, 2023
@turadg
Copy link
Member Author

turadg commented Feb 13, 2023

Fixed by #6976

Confirmed by making the edits in the gist's diff and seeing the types without error

@dckc dckc closed this as completed Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turadg turadg

Labels
bug Something isn't working devex developer experience vaults_triage DO NOT USE
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@turadg @dckc @rowgraus