Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parameterize type of contractGovernor #6987

Open
turadg opened this issue Feb 12, 2023 · 0 comments
Open

parameterize type of contractGovernor #6987

turadg opened this issue Feb 12, 2023 · 0 comments
Assignees
@turadg
Labels
devex developer experience enhancement New feature or request Governance Governance vaults_triage DO NOT USE

Comments

@turadg
Copy link
Member

turadg commented Feb 12, 2023

What is the Problem Being Solved?

contractGovernor contract loses the types of its governed contract.

Description of the Design

Make it generic on its governed contract start fn.

Salvage changes from #6963

Security Considerations

Scaling Considerations

Test Plan

Add types tests
@turadg turadg added enhancement New feature or request devex developer experience Governance Governance labels Feb 12, 2023
@turadg turadg self-assigned this Feb 12, 2023
@turadg turadg mentioned this issue Feb 12, 2023
Merged
@ivanlei ivanlei added this to the Vaults EVP milestone Feb 13, 2023
@ivanlei ivanlei added the vaults_triage DO NOT USE label Feb 13, 2023
@ivanlei ivanlei removed this from the Vaults EVP milestone Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turadg turadg

Labels
devex developer experience enhancement New feature or request Governance Governance vaults_triage DO NOT USE
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turadg @ivanlei