Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Bidding interface wantCollateral required when bidding by-price #7268

Closed
arirubinstein opened this issue Mar 29, 2023 · 3 comments
Closed
Labels
auction bug Something isn't working vaults_triage DO NOT USE
Milestone

Comments

@arirubinstein
Copy link
Contributor

Describe the bug

The bidding interface is confusing currently, when specifying a price, it also requires the wantCollateral. If this information can be implied by the price argument and giveCurrency param, requiring the user to provide this is not ergonomic.

To Reproduce

Steps to reproduce the behavior:

  1. agops inter bid by-price --price 0.80 --giveCurrency 10
  2. see error about required wantCollateral

Expected behavior

A bidding user should be able to specify the minimum input required to make a bid instead of having to calculate the wanted collateral

@arirubinstein arirubinstein added the bug Something isn't working label Mar 29, 2023
@dckc
Copy link
Member

dckc commented Mar 29, 2023

I tried tweaking the CLI this way, but then I got: Error: (an object) - Must have missing properties ["want"]

This seems to be a contract issue as well as CLI:

{ want: collateralAmountShape },

cc @Chris-Hibbert @turadg

@Chris-Hibbert
Copy link
Contributor

I'm not convinced that the bidSpec's want (though admittedly mis-named) is extraneous. There are two ways of specifying a bid: by price and by discount

  • I'm willing to spend 37 IST per ATOM, and I want 100. I might get only 50, and they might only cost me 35 IST each. I don't have to give 3700 IST in order to make this bid.
  • I'd like to buy ATOM at a 80% of the oracle price, and I'd like up to 1000. The amount of IST I provide is unrelated to how many I'd like to acquire.

@dckc dckc added the auction label Mar 30, 2023
@otoole-brendan otoole-brendan added the vaults_triage DO NOT USE label Apr 3, 2023
@otoole-brendan otoole-brendan added this to the Vaults EVP milestone Apr 3, 2023
@dckc
Copy link
Member

dckc commented Apr 5, 2023

fixed in #7256:

$ agops inter bid by-price --price 0.80 --give 10IST --from gov1
2023-04-05T18:11:44.932548675Z tx not in block 5617 retrying...

@dckc dckc closed this as completed Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auction bug Something isn't working vaults_triage DO NOT USE
Projects
None yet
Development

No branches or pull requests

4 participants