Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update x/vibc to support Agoric ibc-hooks middleware #9029

Closed
michaelfig opened this issue Mar 4, 2024 · 0 comments · Fixed by #9030
Closed

Update x/vibc to support Agoric ibc-hooks middleware #9029

michaelfig opened this issue Mar 4, 2024 · 0 comments · Fixed by #9030
Assignees
Labels
enhancement New feature or request

Comments

@michaelfig
Copy link
Member

What is the Problem Being Solved?

The current Golang x/vibc module is built only for JS contracts to use directly. It is not suited to implementing middleware to handle IBC apps that are already written in Golang.

With a little bit of work, x/vibc could also be used to intercept Golang IBC app upcalls and downcalls, and forward them to JS for handling.

Description of the Design

Implement IBC_EVENT messages destined for the JS VM that would be triggered by upcalls from Golang "Agoric ibc-hooks" middleware as well as the (currently supported) ibc-go core modules. Also implement IBC_METHOD messages destined for the JS VM that can be triggered by IBC apps that are wrapped by Golang "Agoric ibc-hooks" middleware.

Because IBC is nearly completely async-tolerant, it pairs well with async calls/replies to and from the Agoric JS VM.

Security Considerations

Middleware needs to be carefully audited. It can exert complete control over the IBC app that it wraps.

Scaling Considerations

No particularly heavy load... just the overhead of contract calls and replies when Golang passes messages over the JS VM bridge.

Test Plan

Implement vtransfer (#8624) using this support and verify it end-to-end.

Upgrade Considerations

No additional considerations beyond making middleware JS target contracts upgradable.

@michaelfig michaelfig added the enhancement New feature or request label Mar 4, 2024
@michaelfig michaelfig changed the title Upgrade x/vibc to support Agoric ibc-hooks middleware Update x/vibc to support Agoric ibc-hooks middleware Mar 4, 2024
@mergify mergify bot closed this as completed in #9030 Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant