[Zoe] Ensure offers have the instance handle of the contract instance #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
approved these changes
Apr 10, 2020
Chris-Hibbert
approved these changes
Apr 10, 2020
… calling the contract facet method
katelynsills
force-pushed
the
773-ensure-offers-have-instance-handle
branch
from
141a4d0 to
d8ace9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #773
Rather than analyzing the Zoe code for #773 to ensure that contracts cannot use offerHandles associated with other contracts, I chose to add assertions to prove that this is the case for all the contract facet methods which take offerHandles as arguments. I think this is more robust than a one-time analysis.