Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PeerDependency to Angular 6 #37

Closed
PascalHonegger opened this issue May 4, 2018 · 3 comments
Closed

Update PeerDependency to Angular 6 #37

PascalHonegger opened this issue May 4, 2018 · 3 comments

Comments

@PascalHonegger
Copy link
Contributor

Angular 6 was released today and I would like to use this package without install warnings. This also includes updating the rxjs peerDependency (even though I don't see how rxjs is required by this package). I tested this component in an angular 6 app without any problem.
@alfaproject
Copy link

rxjs isn't required and should be removed from peer dependencies.

@PascalHonegger PascalHonegger mentioned this issue May 17, 2018
Merged
@AhsanAyaz
Copy link
Owner

Thanks again @PascalHonegger .
#39 closed this issue.

@AsimNet
Copy link

AsimNet commented Nov 12, 2018

same thing with Angular7

@the-destro the-destro mentioned this issue Jan 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alfaproject @AsimNet @AhsanAyaz @PascalHonegger