Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing example is not update to latest package guidelines #5

Open
AsafAgranat opened this issue Mar 15, 2017 · 8 comments
Open

Routing example is not update to latest package guidelines #5

AsafAgranat opened this issue Mar 15, 2017 · 8 comments

Comments

@AsafAgranat
Copy link

I've updated vue-router2 to latest release. The routing example is setup according to previous releases. So if one follows the example, it leads to console errors. It took me some guesswork to get it running again. I encountered the following issues that prevented the app from running:

  • In the latest release the guidelines asks to import RouterFactory, whereas previously it was Router
  • Starting the router changed to routerFactory.create(), whereas previously it was Router.start()
@Akryum
Copy link
Owner

Akryum commented Mar 15, 2017

Yes, I need to update this example 😄

@lunatolun
Copy link
Contributor

+1

@Ethaan
Copy link

Ethaan commented Apr 10, 2017

That will be sooo nice

@thearabbit
Copy link

+1, please I need too

@thearabbit
Copy link

Please example with imports, startup... Structure

@lunatolun
Copy link
Contributor

I actually figured it out. I can do a boilerplate tomorrow with

atmosphere:
akryum:meteor-vue-component

npm:
vue
vue-router
vuex

One with akryum:vou-router2, one without. I actually figured it out but then moved to official vue-router. I'll do both if I find the time. Cheers

@thearabbit
Copy link

thearabbit commented May 3, 2017

@lunatolun, now I tried native vue-router without akryum:vou-router2, It work fine.
Please advice, which better for native vue-router vs akryum:vou-router2?
Should I use???

@lunatolun
Copy link
Contributor

lunatolun commented May 6, 2017

@thearabbit To be honest I don't really know the exact details except the file format. Akryum said this on meteor forums:

Provides a set of helpers to put routes in a more Meteor-ish style (plus a handy special file format). It's completely optional.

Here is the Meteor - Vue - VueRouter - Vuex config repo using vue-router from npm: meteor-vue-vuerouter-vuex

I sent a PR for updated routing example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants