Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundled CDN shows wrong version #117

Closed
Tracked by #126
blackfalcon opened this issue May 19, 2021 · 3 comments · Fixed by #145
Closed
Tracked by #126

Bundled CDN shows wrong version #117

blackfalcon opened this issue May 19, 2021 · 3 comments · Fixed by #145
Assignees
Labels
auro-button Type: Bug Bug or Bug fixes

Comments

@blackfalcon
Copy link
Member

Describe the bug

With the latest update to auro-button there is a new feature that shows the version of the element in the scope of the HTML.

This is not working as expected with pre-bundled assets as the version is updated in the repo PRIOR to bundling.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://auro.alaskaair.com/components/auro/button
  2. Inslect on any button
  3. Look to find version=""
  4. It will show the previous version

Expected behavior

It shows the current version

@blackfalcon blackfalcon added the Type: Bug Bug or Bug fixes label May 19, 2021
@blackfalcon blackfalcon self-assigned this May 19, 2021
@blackfalcon
Copy link
Member Author

A thought is to use Semantic Release to do a dry-run and determine the next version released and use that value for the version.js file, then that value would be available for the bundled build BEFORE semantic release merges back to the Git repo with the updated version.

@blackfalcon
Copy link
Member Author

@blackfalcon blackfalcon changed the title auro-button: bundled CDN shows wrong version Bundled CDN shows wrong version Aug 18, 2021
@blackfalcon
Copy link
Member Author

The current recommendation is to remove this feature from the auro-button and re-think the approach in an alternate element.

@blackfalcon blackfalcon removed their assignment Aug 19, 2021
@blackfalcon blackfalcon mentioned this issue Aug 19, 2021
6 tasks
@blackfalcon blackfalcon added this to the v7.0-rc milestone Sep 3, 2021
@blackfalcon blackfalcon removed the Type: Bug Bug or Bug fixes label Sep 4, 2021
@blackfalcon blackfalcon removed this from the v7.0-rc milestone Sep 4, 2021
@blackfalcon blackfalcon added Type: Bug Bug or Bug fixes and removed Issue labels Sep 4, 2021
@braven112 braven112 added this to the auro-button v6.4-rc milestone Dec 21, 2021
@jason-capsule42 jason-capsule42 self-assigned this Jan 18, 2022
@jason-capsule42 jason-capsule42 linked a pull request Jan 18, 2022 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auro-button Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants