Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auro-hyperlink: semantic theming for sizing #196

Closed
4 tasks
braven112 opened this issue Jan 18, 2024 · 2 comments
Closed
4 tasks

auro-hyperlink: semantic theming for sizing #196

braven112 opened this issue Jan 18, 2024 · 2 comments

Comments

@braven112
Copy link
Member

This issue is related to this issue AlaskaAirlines/auro-button#243

Needs a tier 2 token

min-height: var(--ds-size-600, $ds-size-600);

max-height: var(--ds-size-600, $ds-size-600);

padding: 0 var(--ds-size-300, $ds-size-300);

padding: var(--ds-size-100, $ds-size-100) var(--ds-size-200, $ds-size-200);

outline: var(--ds-color-ui-default-default, $ds-color-ui-default-default) solid var(--ds-size-50, $ds-size-50);

--auro-size-lg: 1rem;

top: var(--ds-size-25, $ds-size-25);

margin-left: var(--ds-size-25, $ds-size-25);

Should use a new tier 2 token. Currently the token describes the value since it references "Darkest" or "Lightest"

background-image: linear-gradient(var(--ds-color-background-lighter, $ds-color-background-lighter), var(--ds-color-background-lighter, $ds-color-background-lighter));

Exit criteria

  • All SASS references have been updated to CSS variables
  • There are no longer tier 1 tokens referenced in this repo.
  • All lines listed have been addressed.
  • All CTA states have tokens. (visited, hover, focus, focus-visible, active, etc.)
@blackfalcon
Copy link
Member

@leeejune is there any suggestions you can offer here to address this work? While this is an update to the hyperlink element, the pre-work for creating these requested tokens is not defined anywhere.

Please advise and a new Tokens issue will need to be created defining that work.

@blackfalcon
Copy link
Member

@leeejune @jason-capsule42 @jordanjones243 this issue is pretty old. Can anyone offer any insight as to if this work still needs to be done?

I am reassigning this to triage for team review.

@Patrick-Daly-AA Patrick-Daly-AA removed their assignment Jul 15, 2024
@Patrick-Daly-AA Patrick-Daly-AA changed the title auro-hyperlink: semantic theming auro-hyperlink: semantic theming for sizing Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants