Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom component registration breaks in surge demos #20

Open
Izook opened this issue Jul 13, 2023 · 0 comments
Open

custom component registration breaks in surge demos #20

Izook opened this issue Jul 13, 2023 · 0 comments
Assignees
Labels
auro-library not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes

Comments

@Izook
Copy link
Contributor

Izook commented Jul 13, 2023

Please describe the bug

  1. Go to http://alaskaairlines-auro-accordion-jbaker-newaccordian.surge.sh/demo/ in auro-accordion#77
  2. Observe demo broken in "Recommended Use and Version Control"

Reproducing the error

None

Expected behavior

The demo works and successfully registers components to a custom name.

What browsers are you seeing the problem on?

No response

Additional context

The issue seems to be coming from surge struggling to consume all the modules that ../index.js is dependent on.

A potential solution would be to update useBundles.js to change the code snippet that completes the custom registration to depend on the bundles instead of ../index.js.

Exit criteria

The custom registration demo works on surge created pages.

@Izook Izook added auro-library not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes labels Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auro-library not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes
Projects
None yet
Development

No branches or pull requests

2 participants