Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auro-dropdownmenu: create figma blueprint file #3

Closed
1 of 2 tasks
Tracked by #1
leeejune opened this issue Nov 12, 2021 · 9 comments
Closed
1 of 2 tasks
Tracked by #1

auro-dropdownmenu: create figma blueprint file #3

leeejune opened this issue Nov 12, 2021 · 9 comments
Assignees
Labels
Status: Work In Progress Issue or Pull Request work is in Progress Type: Design New or related Design work

Comments

@leeejune
Copy link

General Support Request

aruo-dropdownmenu requires a blueprint supporting document to be released to Figma.

Support request

Review the current state of the auro-dropdownmenu design and create the Figma blueprint document.

Possible Solution

Design to review current UI for new design opportunities.

Exit Criteria

  • complete blueprint work (Link)
  • signoff from Auro engineering (TBD)
@leeejune leeejune added not-reviewed Issue has not been reviewed by Auro team members Status: Proposal labels Nov 12, 2021
@leeejune leeejune added Status: Review Needed and removed not-reviewed Issue has not been reviewed by Auro team members Status: Proposal labels Nov 12, 2021
@jason-capsule42
Copy link
Member

Screen Shot 2021-11-16 at 9 06 29 AM

The spacing defined here should be part of the auro-dropdown design spec and not auro-dropdownmenu.

@leeejune
Copy link
Author

@jason-capsule42 Is it possible to add internal spacing to menu only on the top and bottom? If so, where should that be added?

@jason-capsule42
Copy link
Member

@jason-capsule42 Is it possible to add internal spacing to menu only on the top and bottom? If so, where should that be added?

@leeejune Do you mean either:

  1. The menu itself has padding on the top and bottom
  2. The first menu item is taller and has extra padding on top AND the last menu item is taller and has extra padding on the bottom?

Both solutions are possible.

@leeejune
Copy link
Author

leeejune commented Nov 17, 2021

@jason-capsule42 I meant the first one! The main objective is just add a bit padding to the overall menu, so either solution works if it looks a bit more padded.
Does this extra padding information belong in dropdown menu?

@leeejune
Copy link
Author

Updated blueprint with new dropdown design.

@blackfalcon
Copy link
Member

Is this correct?

Screen Shot 2021-11-24 at 9 42 14 AM

In the rest of the document, I am not funding a definition of a toggle in menudropdown that is not outlined?

@braven112 braven112 added this to the v1.0-rc milestone Nov 24, 2021
@leeejune
Copy link
Author

@blackfalcon The borderless versions are in auro-dropdown's blueprint. Should I add it here as well?

@blackfalcon
Copy link
Member

@blackfalcon The borderless versions are in auro-dropdown's blueprint. Should I add it here as well?

No. We are good.

@blackfalcon blackfalcon added auro-dropdownmenu Type: Design New or related Design work Status: Work In Progress Issue or Pull Request work is in Progress labels Dec 19, 2021
@jason-capsule42
Copy link
Member

Reviewed with June and we can close this ticket as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Work In Progress Issue or Pull Request work is in Progress Type: Design New or related Design work
Projects
None yet
Development

No branches or pull requests

4 participants