Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce error message prop #65

Closed
geoffrich opened this issue Apr 22, 2022 · 4 comments
Closed

Introduce error message prop #65

geoffrich opened this issue Apr 22, 2022 · 4 comments
Labels
auro-select not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes
Milestone

Comments

@geoffrich
Copy link

Is your feature request related to a problem? Please describe.

auro-select supports an error state with a red border, but does not support displaying an error message. In my application I need to show an error associated with a select, e.g. "Please select an option"

Describe the solution you'd like

Introduce a prop so that an error message can be displayed.

Describe alternatives you've considered

Handle showing the error message in my application code, e.g.

<auro-select error={showError}>
    <!-- truncated for readability -->
</auro-select>
{#if showError}
    <p class="errorText">{error}</p>
{/if}

Though this solution is not properly associated with the select using aria-describedby. An solution inside the component would make that easier.

Additional context

Prior art in auro-input:

image

@geoffrich geoffrich added not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature auro-select labels Apr 22, 2022
@blackfalcon
Copy link
Member

@leeejune I am not finding the error state for this element in the blueprints? https://www.figma.com/file/nyXRAgG4YzZaGdIVmPwARP/Select?node-id=322%3A298

Is this defined?

@blackfalcon blackfalcon added the Type: Bug Bug or Bug fixes label Apr 25, 2022
@blackfalcon
Copy link
Member

Not sure yet to define this as a bug or a new feature.

@blackfalcon blackfalcon added this to the auro-select v2.3-rc milestone Apr 25, 2022
@leeejune
Copy link

Since it uses input, I didn't display the other states; I assumed that it would inherit all of input's states... should I display all of the states?

@braven112 braven112 removed the not-reviewed Issue has not been reviewed by Auro team members label Apr 25, 2022
@blackfalcon blackfalcon added the not-reviewed Issue has not been reviewed by Auro team members label Oct 12, 2022
@blackfalcon
Copy link
Member

Closing issue in favor of new feature work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auro-select not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes
Projects
None yet
Development

No branches or pull requests

5 participants