Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to time #1

Closed
griffi-gh opened this issue May 12, 2022 · 3 comments
Closed

Switch to time #1

griffi-gh opened this issue May 12, 2022 · 3 comments

Comments

@griffi-gh
Copy link

chrono depends on an old version of time which has multiple security issues and hasn't been updated for an entire year
@AlephAlpha
Copy link
Owner

Thanks for letting me know about that.

It seems that the security issue of chrono is caused by getting the local time in multi-threaded program: chronotope/chrono#499. This means that my build_time_local macro might be unsound. time had a similar issue (time-rs/time#293), and its solution is returning an error unless the program is single-threaded.

I don't know how to work around this. Should I simply remove the build_time_local macro?

@AlephAlpha
Copy link
Owner

Maybe I should just wait until chrono merge chronotope/chrono#677.

@AlephAlpha
Copy link
Owner

chrono 4.20 is finally released, and the security issue is fixed. I will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlephAlpha @griffi-gh