From 51cf7e85276862b04ec8ef2ecdbc09d602887095 Mon Sep 17 00:00:00 2001
From: AlexWaygood <alex.waygood@gmail.com>
Date: Sun, 5 Mar 2023 18:26:05 +0000
Subject: [PATCH] gh-102433: Add tests for how properties interact with
 `typing.runtime_checkable` protocols

---
 Lib/test/test_typing.py | 106 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 106 insertions(+)

diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py
index 2eeaf91d78d8f30..94bdbfc276f4c2c 100644
--- a/Lib/test/test_typing.py
+++ b/Lib/test/test_typing.py
@@ -2535,6 +2535,112 @@ def meth(x): ...
         with self.assertRaises(TypeError):
             isinstance(C(), BadPG)
 
+    def test_protocols_isinstance_simple_properties(self):
+        T = TypeVar('T')
+
+        @runtime_checkable
+        class P(Protocol):
+            @property
+            def attr(self): ...
+
+        @runtime_checkable
+        class P1(Protocol):
+            attr: int
+
+        @runtime_checkable
+        class PG(Protocol[T]):
+            @property
+            def attr(self): ...
+
+        @runtime_checkable
+        class PG1(Protocol[T]):
+            attr: T
+
+        class BadP(Protocol):
+            @property
+            def attr(self): ...
+
+        class BadP1(Protocol):
+            attr: int
+
+        class BadPG(Protocol[T]):
+            @property
+            def attr(self): ...
+
+        class BadPG1(Protocol[T]):
+            attr: T
+
+        class C:
+            @property
+            def attr(self):
+                return 42
+
+        self.assertEqual(C().attr, 42)
+        self.assertIsInstance(C(), P)
+        self.assertIsInstance(C(), P1)
+        self.assertIsInstance(C(), PG)
+        self.assertIsInstance(C(), PG1)
+        with self.assertRaises(TypeError):
+            isinstance(C(), PG[T])
+        with self.assertRaises(TypeError):
+            isinstance(C(), PG[C])
+        with self.assertRaises(TypeError):
+            isinstance(C(), PG1[T])
+        with self.assertRaises(TypeError):
+            isinstance(C(), PG1[C])
+        with self.assertRaises(TypeError):
+            isinstance(C(), BadP)
+        with self.assertRaises(TypeError):
+            isinstance(C(), BadP1)
+        with self.assertRaises(TypeError):
+            isinstance(C(), BadPG)
+        with self.assertRaises(TypeError):
+            isinstance(C(), BadPG1)
+
+    def test_protocols_isinstance_dynamic_properties(self):
+        T = TypeVar('T')
+
+        @runtime_checkable
+        class P(Protocol):
+            @property
+            def attr(self): ...
+
+        @runtime_checkable
+        class P1(Protocol):
+            attr: int
+
+        @runtime_checkable
+        class PG(Protocol[T]):
+            @property
+            def attr(self): ...
+
+        @runtime_checkable
+        class PG1(Protocol[T]):
+            attr: T
+
+        class C:
+            X = False
+            @property
+            def attr(self):
+                if self.X:
+                    return 42
+                raise AttributeError
+
+        inst = C()
+        with self.assertRaises(AttributeError):
+            inst.attr
+        self.assertNotIsInstance(inst, P)
+        self.assertNotIsInstance(inst, P1)
+        self.assertNotIsInstance(inst, PG)
+        self.assertNotIsInstance(inst, PG1)
+
+        C.X = True
+        self.assertEqual(inst.attr, 42)
+        self.assertIsInstance(inst, P)
+        self.assertIsInstance(inst, P1)
+        self.assertIsInstance(inst, PG)
+        self.assertIsInstance(inst, PG1)
+
     def test_protocols_isinstance_py36(self):
         class APoint:
             def __init__(self, x, y, label):