Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split main #9

Merged
merged 3 commits into from
Jul 4, 2021
Merged

Split main #9

merged 3 commits into from
Jul 4, 2021

Conversation

mpre
Copy link
Contributor

@mpre mpre commented May 5, 2021

WORK IN PROGRESS / EXPERIMENTAL, DON'T MERGE

Add index and call sub-commands

This commit splits malva-geno into two different steps:

  • malva-geno index will parse the reference, build the bloom filters and dump them into .malvax
  • malva-geno call will call the variants, loading the index from .malvax

The interface needs reworking, right now both commands expect the same arguments.

This commit splits malva-geno into two different steps:
* malva-geno index will parse the reference, build the bloom filters and
  dump them into <vcfname>.malvax
* malva-geno call will call the variants, loading the index from <vcfname>.malvax

The interface needs reworking, right now both commands expect the same arguments.
@mpre mpre requested a review from ldenti May 5, 2021 17:25
@mpre
Copy link
Contributor Author

mpre commented May 5, 2021

This will obviosuly break the interface. When/if merged, we'd better publish this on bioconda bumping the main version.

@mpre mpre linked an issue May 5, 2021 that may be closed by this pull request
@mpre mpre added the enhancement New feature or request label May 5, 2021
@mpre mpre changed the base branch from master to path_to_version_2_0 May 24, 2021 09:46
@mpre mpre changed the title WIP: Split main Split main May 24, 2021
@mpre
Copy link
Contributor Author

mpre commented May 24, 2021

Changed the target branch to path_to_version_2_0 that is a dev branch so we can merge

@mpre mpre requested a review from yp May 24, 2021 09:47
@mpre mpre merged commit 424acf5 into path_to_version_2_0 Jul 4, 2021
@yp yp deleted the split_main branch March 24, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speeding up malva using more threads
1 participant