Fix bugs relating to the log detail page #26
Conversation
| ], | ||
| }); | ||
| const read = async (request, response, next) => { | ||
| if (isNaN(request.params.id)) { |
There was a problem hiding this comment.
This logic should be wrapped in a DTO, see the CreateLogDto as an example.
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
- Coverage 93.57% 93.25% -0.32%
==========================================
Files 79 81 +2
Lines 1011 1067 +56
Branches 37 44 +7
==========================================
+ Hits 946 995 +49
- Misses 65 72 +7
Continue to review full report at Codecov.
|
john-ghatas
force-pushed
the
fix/detail-page
branch
from
c0156ef to
5080850
Compare
| * @param {Number} id ID of the entity to retrieve. | ||
| * @returns {Promise} Promise object represents the result of this use case. | ||
| */ | ||
| async execute(id) { |
There was a problem hiding this comment.
See the comment regarding DTO
john-ghatas
force-pushed
the
fix/detail-page
branch
from
9ead3c8 to
9ba7587
Compare
|
Something is going wrong with coverage. Will investigate into this tomorrow. |
|
Coverage should be much higher now. |
|
@MauritsioRK the OpenAPI checks if there are any breaking changes, so this is not something to worry about (that much) at this stage but is nice to know. |
These two tickets are addressed by the PR:
https://alice.its.cern.ch/jira/browse/O2B-260
https://alice.its.cern.ch/jira/browse/O2B-261
This also includes some error handling for a missing log entry.