Mangahere latest chapter broken #156
Comments
|
Seems like Mangafox has also been struck with the same problem. |
|
From what I can tell, it might be because MangaHere just switched to htpps. Would need to change the rule here https://community.allmangasreader.com/latest_v2/MangaHere.js |
|
I am writing a really quick fix for it that is probably going to increase latency but at least it will fix the issue. I can share it once I'm at a point that's worth sharing if you're interested. |
|
Another fix could be changing the .attr("href") to just .href in https://github.com/AllMangasReader-dev/mirrors/blob/master/MangaHere.js. That would make it so that it returns the complete url with the https:// as opposed to just // but I haven't had the chance to test that yet. |
|
Nice, good work. Too bad I suck at java. Meaning that I can't help much. |
|
Nice, good work. Too bad I suck at java.
Actually javascript.
|
|
Anything with java in the name, I suck at. |
|
Hi, sorry to bother, but the chrome extension of All Mangas Reader versions 1.5.10.2 is not working can I know if you will make a new extension, fix I really love this extension been using it a long time and I check github but I don't know Java script. |
|
I use AMR as an unpacked extension, and only thing i've edited is this line of Do i have to edit some file with this? Edit: Using |
|
So right now I was in the middle of a quick fix which was basically appending https: to every mangahere url since it seems that its returning as //www.mangahere.co/* as opposed to http://ww.mangahere.co. I'm not sure if it has to do with the fact that mangahere switched to https. MY solution fixes the issue but it might create some latency issues. Right now it detects that if you're in the last chapter then there's no new chapter but I'm still having some issue with updating what's the latest chapter. Once I get that part done I will fork it and share it. |
|
From the little investigating I did yesterday night, I noticed that if you go to a mangahere detail page such as https://www.mangahere.co/manga/14_sai_no_koi/ and then you can see from https://github.com/AllMangasReader-dev/mirrors/blob/84c4a8f370b116c9b0edd798116de60067207e1e/MangaHere.js#L52-L54 that it uses .attr('href') to fetch the url. If you go to the detail page and run Same issue on https://github.com/AllMangasReader-dev/mirrors/blob/84c4a8f370b116c9b0edd798116de60067207e1e/MangaHere.js#L75-L77 By using .attr("href") we are getting how they wrote it but if we use .href then we get the absolute path. |
|
https://github.com/twluo/AMR Is a very dirty fix but it gets stuff working. There's still some issues with the counter. It seems that the counter doesn't refresh properly but you can get it to refresh by just reloading the extension. |
|
Good job. Though if you are able to grab the correct URL by changing the Mangahere.js, why are you editing the files in the main js folder? Pardon my noobness. |
|
I'm not sure how the mirrors work and I don't really want to spent an entire night investigating it. I try copying the MangaHere.js into my local and try to use the local mirror instead of the repo one but it kept failing so I gave up. Also I just updated my fork and should be able to refresh properly. |
|
Nice. Good job. |
|
Did you use my version? Help me test :) If you find any issue besides latency notify me. |
|
On your version I'm having 2 issues, the mark latest chapter as read doesn't seem to be working even with reloading the extension. Also the options button doesn't work and just brings it to "https://options.html/", the options button under chrome://extensions/ does work fine though. |
|
Actually I don't think any of the buttons work anymore in the menu. |
|
testing it right now |
|
Maybe I messed up when I was cleaning the code. Because it works on the one I have loaded which was pre-cleaned up. Oh I never used those buttons so I didn't bother testing I know what's wrong. Also the mark latest I might have fixed it on the most recent change. When did you pull my changes? |
|
for me no problems yet. |
|
I pulled the 6cfd713 commit. |
|
@Vuzrak I fixed the settings issue. Tried to make it a bit more generic but it didn't work out. So I specify it to MangaHere should work now. |
|
Also to use the mirror locally you would have to host the files yourself and modify the mgEntry.js to get it to work. |
|
Options working now, but the mark as seen still isn't. |
|
I did that but it wasn't working and I didn't really have the energy to look into it. I might try over the weekend. Anyways I can't reproduce the issue with the mark as read. Let me upload the "unclean" code. |
|
ok, all Mangahere chapters have to be manually reloaded for there to be a working entry. The old one does not work, AMR would create a new working entry once you load the latest chapter. However, Mangafox load full chapter option is broken. |
|
What I did was export the mangaList and then use a text editor to change all the urls to have https:// and then re import it. |
|
@Vuzrak have you worked with local mirrors? You could try what I suggested and see if it works. |
|
Weird, the mark read still doesn't work, gonna just try uninstalling extension and reinstalling it. I tried your changes but they didn't seem to work, it's probably I didn't understand exactly all that was needed. |
|
I was using this https://raw.githubusercontent.com/twluo/mirrors/master/MangaHere.js So is working fine now? |
|
There are some minor stuff, was just messing around to make it pass the lab test. For normal use I haven't seen any issue with the previous configuration |
|
I see. |
|
Im not at the computer right now, but can someone just archive thier chrome folder extension of all mangas reader with the fixes and put it online on drive or dropbox? |
|
You can just download from twluo's gtihub here. You know it's a good day when you have to manually reload 600+ manga. |
|
What do you mean by manually reload? Btw I added support to use https://github.com/twluo/mirrors/blob/master/MangaHere.js as a Mirror so no need to have the local Mirror anymore. So I think it should work as is now. |
|
For me, all the old entries of the manga does not work. I need to reload a chapter to get a new entry in, and delete the old entry... |
|
So for that I just export it and then do a replace all <"//www.mangahere.co> to <"https://www.mangahere.co"> and also a <"http://www.mangahere.co> to <"https://www.mangahere.co> and import it back. Try that it might work. |
|
I can try taking a look at Mangafox during the weekend. I think I spent too much time on JS for a bit. @.@ |
|
Yup, I did the same thing, export it, search/replace, import it back in. |
|
@Vuzrak I updated the repo to fetch the mirror rules from the other repo as opposed to local that way it will be easier to mantain. So if you haven't I suggest you update it. |
|
If you find any other issue either comment it here or raise it on my repo and I can take a look tomorrow. |
|
So i just export my |
|
After you did the first replace, it's enough... there's no need to add in the second replace.... |
|
That and the 2nd replaced you added an extra " |
|
Okay. Will try doing it over. But not adding the extra "
|
|
Just do a replace on "http://www.mangahere" to "https://www.mangahere" without the quotes. |
|
Doing But doing just |
|
I'm having the problem for loading all pages on Mangahere again. I applied the fix by @twluo and it's actually fixed (thanks man), but yesterday the problem came back and I can't load all pages in the chapter now (inb4 MH dev is secretly lurking this place). I've already checked the "load scans in oder of chapter" and "save bandwidth" in the option. New chapter alert is still working tho. |
|
MangaHere is dead in regards to that, there are some server issues or something is happening. I haven't had the time to look into it |
|
Update: just turn off and on my pc, and suddenly mangahere magically works, without any loading issue. That is that I guess. I feel dumb right now. Thanks for putting up with my crap |
|
i have the same problem as noodle27, i applied the fix by twluo, and it still can't load all pages in the chapter, (only 17%, 34% of it), i already checked the "load scans in oder of chapter" and "save bandwidth" in the option also |
|
Sorry to dug this thread up, but I've encountered another serious problem with Mangahere. So my AMR was having a problem, it won't save my progress after I quited browser. To make it easier to understand:
My only way to counter this was just export the reading list before quitting browser, then import it again the next time I open it. This happens to ALL manga in my list. So I tried to remove AMR and reinstall it ( @twluo 's fix is applied), but after I'm done importing the list, another problem popped up:
Not sure if the previous problem is fixed or not. Anyone can help me on this? |
|
Forgot to update. I cleared out everything of AMR then install it again using https://github.com/twluo/AMR and it worked out well, at least for me. Both reading progress marking problem and mangahere not loading problem are gone. Not sure if the reading progress marking will come back or not tho, because last time it suddenly came out of nowhere too |
|
Yeah, just try it 1h ago |
AMR is wrongly updating all Mangahere latest chapters. All the latest chapters from Mangahere seem to have a file:// added in at the beginning.
With ref to here.
The text was updated successfully, but these errors were encountered: