Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter Display on Long Manhwa #80

Open
bessx opened this issue Jun 17, 2013 · 4 comments
Open

Chapter Display on Long Manhwa #80

bessx opened this issue Jun 17, 2013 · 4 comments

Comments

@bessx
Copy link
Member

bessx commented Jun 17, 2013

@braiam Hey, I know you worked on the Batoto long page manga display, but I don't think we should break them up. We should put them back to back to make a long flowing image. If the user wants them broken up, they can always just click the "Page by Page mode" and AMR will handle it as it usually does. For the full (longpage) mode on Batoto I think it's better to either leave it as is or only change the black background/AMR bar.

@braiam
Copy link
Member

braiam commented Jun 17, 2013

Umm... then the right/left arrows hotkeys wouldn't work and that's the selling poing (check Easygoing site, everything there works just fine). Also, the images are not centered in the batoto default format and centering them breaks somehow the banner in the left.

And, just as kinda cheery in the top thing... why you pm'ing me from here? 😲

@bessx
Copy link
Member Author

bessx commented Jun 18, 2013

hahaha sorry!!! i was js here so i thought i'd bring it up. It's true that the left-right key functionality would be broken, but there's a button right on the top of the page that says "Want to see this chapter per page instead?". In that mode, AMR would work properly and it centers it properly. There's no reason to have AMR do the same exact thing on the longpage mode, is there? It would be better to only do a few changes in that case. (Such as centering and black background and amr bar)

And sorry for msging you on here, I was js playing with the new github design!

@bessx
Copy link
Member Author

bessx commented Jun 18, 2013

also, the reason it doesnt center properly is probably the little box on the top right. It's in a div that's float:right:

<div style="width:22%; text-align-left; float:right;">
<div style="width: 150px; padding: 5px; border-radius: 3px; background-color: #555555; margin-bottom: 10px; text-align: center; margin: 0 auto;">
<a href="?supress_webtoon=t" rel="nofollow" style="color: white; font-weight: bold;">Want to see this chapter per page instead?</a>
</div>

@bessx
Copy link
Member Author

bessx commented Jun 18, 2013

Actually I think it's the Width: 77% div right below that that's glitching the centering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants