Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docking: migration strategy #624

Closed
gucio321 opened this issue Dec 3, 2022 · 2 comments · Fixed by #628
Closed

docking: migration strategy #624

gucio321 opened this issue Dec 3, 2022 · 2 comments · Fixed by #628
Labels
Docking Features from ImGui's "docking" branch

Comments

@gucio321
Copy link
Collaborator

gucio321 commented Dec 3, 2022

Hi @AllenDang !
I have some toughts about migrating to cimgui-go, I'd like to discuss with you:
in my opinion, right now, master and docking are getting a diff on their content. Some bugs, has been fixed on master, but they still exists on docking. This hole is going to grow more an dmore in my opinion, so I see 2 solutions:

  • stop developing docking branch and focus on cimgui-go first (as far as I can see, everything in that repo is still changing - including naming convention e.t.c.) so working on docking now is Sisyphean work. Over that, many things (imo) to migrate to cimgui-go, could be done simply by using Regular Expressions, so we can simply write them down somewhere (e.g. in this issue) and simply use sed to apply them
  • tag current master, drop docking, and start "live-migration" on master branch.
@AllenDang
Copy link
Owner

stop developing docking branch and focus on cimgui-go first

Agree.

tag current master, drop docking, and start "live-migration" on master branch.

Branching is born to situation like this, we could freeze mater branch until docking is ready and merged, you think?

many things (imo) to migrate to cimgui-go, could be done simply by using Regular Expressions

Might not be that easy, but we could fix som corner cases later.

@gucio321
Copy link
Collaborator Author

gucio321 commented Dec 6, 2022

sorry, I'm back 😄

Branching is born to situation like this, we could freeze mater branch until docking is ready and merged, you think?

Sadly, I suppose we need to start migration from scratch, since the hole between the two branches might be too big now and we can miss some stuff

Might not be that easy, but we could fix som corner cases later.

IMO regexp is quit nice tought. I did some work here in my repo.
This branch, could be clearly rebased onto master at any time!

@gucio321 gucio321 added the Docking Features from ImGui's "docking" branch label May 9, 2023
@gucio321 gucio321 linked a pull request May 9, 2023 that will close this issue
69 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docking Features from ImGui's "docking" branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants