Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with addDendrogramMarkers() #17

Open
xuehanci opened this issue May 1, 2024 · 1 comment
Open

Issue with addDendrogramMarkers() #17

xuehanci opened this issue May 1, 2024 · 1 comment

Comments

@xuehanci
Copy link
Collaborator

xuehanci commented May 1, 2024

In the example build_taxonomy.md, there is this step that adding markers to dendrogram for the parent taxonomy addDendrogramMarkers(). And then create the patchseq child taxonomy.
However this step is giving me error after the recent changes with scrattch.taxonomy:
#Error in AIT.anndata$uns$QC_markers[[mode]][["de_genes"]] <- de.genes : more elements supplied than there are to replace

I realized that addDendrogramMarkers() is also embedded within buildPatchseqTaxonomy(), if I don't run addDendrogramMarkers() after buildTaxonomy() and just run buildPatchseqTaxonomy(), it doesn't give me any error. (Steps in build_MTG_patchseq_taxonomy.md)

I am wondering if addDendrogramMarkers() is still needed after build_taxonomy().

@UCDNJJ
Copy link
Collaborator

UCDNJJ commented May 3, 2024

I'll take a look into this, I was having the same error last week. Ideally you should be able to run addDendrogramMarkers at any point! Thanks for catching this error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants